-
Notifications
You must be signed in to change notification settings - Fork 30
fix: bugs in zpopmin/zpopmax; #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@fabianfett @0xTim pls review! :) |
|
Has this project been forgotten? |
|
@iwecon it's been superceded by the official Valkey client: https://github.com/valkey-io/valkey-swift |
Ah, okay. Is this repository no longer being maintained? |
@iwecon practically yes, however I can merge the changes and do a release for this given it's a small patch |
0xTim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@iwecon I don't permissions to bypass the checks so you'll need to get CI passing |
Details: #135
Because
zadddefaults to (RESPValue, Double),scoreIsFirstis set tofalseby default.zaddfunction: